This repository was archived by the owner on Dec 24, 2022. It is now read-only.
Initial Commands Added - looking for feedback #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense. I started on the operator overloading initially but I wasn't sure since currently there isn't much with that in the native client. Update coming soon |
mythz
added a commit
that referenced
this pull request
Jun 11, 2013
Initial Commands Added - looking for feedback
|
Brilliant, thx Michael - it looks much nicer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demis,
I started on this and when I went to begin adding the commands to the RedisClient and some tests I wasn't sure of how to handle the overlap between the existing SETEX, SETNX, and PSETEX commands that this will potentially be replacing in the future.
If you could give some feedback in how you would like that handled I'll finish up the code so this can be merged.