Skip to content

Testing cleanup: remove redundant tests, reduce memory usage, replace materialize_meta_tensors #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 19, 2025

Conversation

jlamypoirier
Copy link
Collaborator

✨ Description

Extracted from #289 to reduce its size:

  • Remove tests in test_mtp and test_ssm that are made redundant by Run tests for all models #289
  • Reduce resource usage of test_preference_logps and test_dropless_mlp.
  • Replace materialize_meta_tensors with the safer get_stage.

🔍 Type of change

Select all that apply:

  • 🐛 Bug fix (non-breaking change that addresses a specific issue)
  • 🚀 New feature (non-breaking change that adds functionality)
  • ⚠️ Breaking change (a change that could affect existing functionality)
  • 📈 Performance improvement/optimization (improves speed, memory usage, or efficiency)
  • 🛠️ Code refactor (non-functional changes that improve code readability, structure, etc.)
  • 📦 Dependency bump (updates dependencies, including Dockerfile or package changes)
  • 📝 Documentation change (updates documentation, including new content or typo fixes)
  • 🔧 Infrastructure/Build change (affects build process, CI/CD, or dependencies)

@jlamypoirier jlamypoirier marked this pull request as ready for review June 13, 2025 21:14
Base automatically changed from model_testing_configs to main June 16, 2025 21:30
@jlamypoirier jlamypoirier merged commit b643cc1 into main Jun 19, 2025
2 checks passed
@jlamypoirier jlamypoirier deleted the cleanup_tests branch June 19, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants