Skip to content

Misc improvements and fixes #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

Misc improvements and fixes #266

merged 4 commits into from
May 21, 2025

Conversation

jlamypoirier
Copy link
Collaborator

@jlamypoirier jlamypoirier commented May 14, 2025

✨ Description

Some misc stuff ectracted from #245 to reduce its size.

  • Replace flaky and poorly formatted __repr__ from dataclass with a formatted config (to_logs)
  • Remove the ignored default_factory for nested config fields.
  • Make instantiation consistent by forcing it to go through _from_dict.
  • Rename model_config_class -> model in ConvertConfig
  • Add some type hints and standardize @config_class to help static type checkers.
  • Various fixes and minor improvements

🔍 Type of change

Select all that apply:

  • 🐛 Bug fix (non-breaking change that addresses a specific issue)
  • 🚀 New feature (non-breaking change that adds functionality)
  • ⚠️ Breaking change (a change that could affect existing functionality)
  • 📈 Performance improvement/optimization (improves speed, memory usage, or efficiency)
  • 🛠️ Code refactor (non-functional changes that improve code readability, structure, etc.)
  • 📦 Dependency bump (updates dependencies, including Dockerfile or package changes)
  • 📝 Documentation change (updates documentation, including new content or typo fixes)
  • 🔧 Infrastructure/Build change (affects build process, CI/CD, or dependencies)

@jlamypoirier jlamypoirier reopened this May 14, 2025
@jlamypoirier jlamypoirier marked this pull request as ready for review May 14, 2025 21:48
@jlamypoirier jlamypoirier mentioned this pull request May 21, 2025
8 tasks
@jlamypoirier jlamypoirier requested review from oleksost and tscholak May 21, 2025 16:25
Copy link
Collaborator

@tscholak tscholak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tscholak
Copy link
Collaborator

I haven't checked the new type annotations with vscode yet, will report back if there are still problems. thanks!

@jlamypoirier jlamypoirier merged commit e1a3d13 into main May 21, 2025
4 checks passed
@jlamypoirier jlamypoirier deleted the misc branch May 21, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants