fix: emit listing LastModified as RFC3339 'Z' (rclone rejects +00:00)#94
Merged
Merged
Conversation
The list serializer formatted timestamps with datetime.isoformat(), which emits a '+00:00' offset. Strict S3 clients reject that: scylla-manager's rclone 1.51.0 fails the whole ListObjects with "parsing time '...+00:00' ... cannot parse '+00:00' as 'Z'", which surfaced as soon as V1 lists started returning data (after the V1->V2 routing fix). Real S3 returns millisecond-precision RFC3339 in UTC with a 'Z' suffix. Add _s3_timestamp() and use it for Contents/LastModified and multipart Initiated. botocore tolerated '+00:00'; rclone does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the V1→V2 routing fix (2026.6.10), the Scylla agent's list no longer 400s — it reaches the backend and returns data. But rclone 1.51.0 then fails parsing the timestamps:
The list serializer formats
LastModifiedwith Python'sdatetime.isoformat(), which emits a+00:00offset. Real S3 returns RFC3339 in UTC with aZsuffix. botocore/aws-sdk tolerate+00:00; scylla-manager's rclone 1.51.0 is strict and rejects the entire listing.Fix
Add
_s3_timestamp()— formats asYYYY-MM-DDTHH:MM:SS.mmmZ(millisecond precision, UTC,Zsuffix, matching real S3) — and use it forContents/LastModifiedand multipartInitiated.Test
tests/unit/test_s3_timestamp.py: UTC →…Zwith millis; non-UTC converted to UTCZ(no+); non-datetime passthrough. Full unit suite green (549 passed); ruff check + format clean.Chain: #91 (V2 token) → #92 (V1→V2 in handler) → #93 (route V1 to handler) → this (timestamp format) — the last hop for the Scylla agent's strict rclone parser.