Builds for Alpine 3.21 broken

[jnoordsij]

Alpine 3.21 was recently released, but it appears that it has broken builds (see e.g. https://github.com/ServerContainers/samba/actions/runs/12225850599).

Debugging a little, I found the issue is the docker image is no longer building due to some build error on wsdd2:

9.596 cc -Wall -Wextra -g -O0   -c -o wsdd2.o wsdd2.c
9.621 wsdd2.c: In function 'open_ep':
9.621 wsdd2.c:305:64: warning: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
9.621   305 |         struct endpoint *ep = (struct endpoint *) calloc(sizeof(*ep), 1);
9.621       |                                                                ^
9.621 wsdd2.c:305:64: note: earlier argument should specify number of elements, later size of each element
9.623 wsdd2.c: In function 'netlink_recv':
9.623 wsdd2.c:546:56: error: initialization of 'int' from 'void *' makes integer from pointer without a cast [-Wint-conversion]
9.623   546 |         struct msghdr msg = { &sa, sizeof sa, &iov, 1, NULL, 0, 0 };
9.623       |                                                        ^~~~
9.623 wsdd2.c:546:56: note: (near initialization for 'msg.__pad1')
9.623 wsdd2.c:546:16: warning: missing initializer for field '__pad2' of 'struct msghdr' [-Wmissing-field-initializers]
9.623   546 |         struct msghdr msg = { &sa, sizeof sa, &iov, 1, NULL, 0, 0 };
9.623       |                ^~~~~~
9.623 In file included from /usr/include/net/if.h:27,
9.623                  from wsdd.h:27,
9.623                  from wsdd2.c:25:
9.623 /usr/include/sys/socket.h:39:13: note: '__pad2' declared here
9.623    39 |         int __pad2;
9.623       |             ^~~~~~
9.636 make: *** [<builtin>: wsdd2.o] Error 1
------
Dockerfile:3
--------------------
   2 |
   3 | >>> RUN apk add --no-cache make gcc libc-dev linux-headers && wget -O - https://github.com/Netgear/wsdd2/archive/refs/heads/master.tar.gz | tar zxvf - \
   4 | >>>  && cd wsdd2-master && make
   5 |
--------------------
ERROR: failed to solve: process "/bin/sh -c apk add --no-cache make gcc libc-dev linux-headers && wget -O - https://github.com/Netgear/wsdd2/archive/refs/heads/master.tar.gz | tar zxvf -  && cd wsdd2-master && make" did not complete successfully: exit code: 2

To work around this, I see a few possibilities (or a combination of):

• provide patch to upstream and wait
• already apply such an above patch here
• alter build flags to turn this error to warning once more
• try using wsdd instead of wsdd2
• (temporarily) remove wsdd2 support on newly built images

[MarvAmBass]

thanks! I'll take a look

[MarvAmBass]

I've patched the issue - it's now working