Skip to content

Commit

Permalink
btrfs: test Btrfs delalloc accounting overflow
Browse files Browse the repository at this point in the history
This is a regression test for patch "Btrfs: fix delalloc accounting
leak caused by u32 overflow". It creates a bunch of delalloc extents
and merges them together to make sure the accounting is done right.

[eguan: use $XFS_IO_PROG instead of xfs_io]

Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
  • Loading branch information
osandov authored and Eryu Guan committed Jun 8, 2017
1 parent 7b6729e commit ff1f614
Show file tree
Hide file tree
Showing 3 changed files with 78 additions and 0 deletions.
75 changes: 75 additions & 0 deletions tests/btrfs/010
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
#! /bin/bash
# FS QA Test 10
#
# Test delayed allocation with a large number of extents that are merged.
# Regression test for patch "Btrfs: fix delalloc accounting leak caused
# by u32 overflow".
#
#-----------------------------------------------------------------------
# Copyright (c) 2017 Facebook. All Rights Reserved.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it would be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#-----------------------------------------------------------------------
#

seq=`basename $0`
seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"

here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15

test_file="$TEST_DIR/$seq"

_cleanup()
{
cd /
rm -f $tmp.* "$test_file"
}

. ./common/rc
. ./common/filter

rm -f $seqres.full

_supported_fs btrfs
_supported_os Linux
_require_test

# Create 32k extents. All of these extents will be accounted as outstanding and
# reserved.
for ((i = 0; i < 32 * 1024; i++)); do
$XFS_IO_PROG -f -c "pwrite $((2 * 4096 * i)) 4096" "$test_file" >>"$seqres.full"
done

# Fill in the gaps between the created extents. The outstanding extents will
# all be merged into 1, but there will still be 32k reserved.
for ((i = 0; i < 32 * 1024; i++)); do
$XFS_IO_PROG -f -c "pwrite $((2 * 4096 * i + 1)) 4096" "$test_file" >>"$seqres.full"
done

# Flush the delayed allocations.
sync

# Make sure that we didn't leak any metadata space.
uuid="$(findmnt -n -o UUID "$TEST_DIR")"
cd "/sys/fs/btrfs/$uuid/allocation"
echo "$(($(cat metadata/bytes_may_use) - $(cat global_rsv_reserved))) bytes leaked" | grep -v '^0 '

echo "Silence is golden"

status=0
exit
2 changes: 2 additions & 0 deletions tests/btrfs/010.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
QA output created by 010
Silence is golden
1 change: 1 addition & 0 deletions tests/btrfs/group
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
007 auto quick rw metadata send
008 auto quick send
009 auto quick subvol
010 auto
011 auto replace
012 auto convert
013 auto quick balance
Expand Down

0 comments on commit ff1f614

Please sign in to comment.