Skip to content

Commit

Permalink
Fix fallocate() test
Browse files Browse the repository at this point in the history
The test for fallocate was broken because it used $TEST_DIR/$tmp.io. Because
$tmp is usually something like /tmp/1234 or /mnt/1234 the file cannot be
created and xfs_io fails regardless of existance of fallocate support. Moreover
the subsequent message parsing decides that fallocate is actually supported
because it does not expect this message.

Fix the test to not use $tmp.

Signed-off-by: Jan Kara <jack@suse.cz>
  • Loading branch information
jankara committed May 24, 2010
1 parent c9ff0c0 commit 2a7c491
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions common.rc
Original file line number Diff line number Diff line change
Expand Up @@ -803,8 +803,9 @@ _require_user()
#
_require_xfs_io_falloc()
{
testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $TEST_DIR/$tmp.io 2>&1`
rm -f $TEST_DIR/$tmp.io 2>&1 > /dev/null
testfile=$TEST_DIR/$$.falloc
testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1`
rm -f $testfile 2>&1 > /dev/null
echo $testio | grep -q "not found" && \
_notrun "xfs_io fallocate support is missing"
echo $testio | grep -q "Operation not supported" && \
Expand Down

0 comments on commit 2a7c491

Please sign in to comment.