Skip to content

FLAC: Simplify tag writes#617

Open
Serial-ATA wants to merge 1 commit intomainfrom
flac-fix
Open

FLAC: Simplify tag writes#617
Serial-ATA wants to merge 1 commit intomainfrom
flac-fix

Conversation

@Serial-ATA
Copy link
Owner

No description provided.

@Serial-ATA Serial-ATA added this to the 0.23.3 milestone Feb 15, 2026
PandorasFox added a commit to PandorasFox/music-magic that referenced this pull request Feb 16, 2026
…EKTABLE bug

lofty 0.23.x reorders metadata blocks when writing, pushing SEEKTABLE
after PICTURE blocks. With preferred_padding(0), no PADDING block exists
to carry the is_last flag, orphaning the SEEKTABLE past the last-flagged
block and corrupting the file (ffprobe: "invalid sync code").

Default WriteOptions includes a trailing PADDING block that absorbs the
is_last flag, keeping the SEEKTABLE inside the metadata region. The
padding sizing issues that motivated preferred_padding(0) were fixed in
lofty 0.23.2.

Upstream fix: Serial-ATA/lofty-rs#617

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant