MPEG: Improve duration calculation #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For files with a VBR header: Thanks to @naglis for correcting the length calculation. (issue: #412) For files without a VBR header: `rev_search_for_frame_header` would get tripped up on files with trailing data that looked like a frame sync (ex. 0xFFFF). This would also result in durations that are slightly off. For now, VBR streams are still assumed to be CBR. I have not seen a file this does not work for yet. Eventually it would be nice to have more accurate calculation, but that will require we read the *entire* file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For files with a VBR header:
Thanks to @naglis for correcting the length calculation. (issue: #412)
For files without a VBR header:
rev_search_for_frame_headerwould get tripped up on files with trailing datathat looked like a frame sync (ex. 0xFFFF). This would also result in durations that are
slightly off.
For now, VBR streams are still assumed to be CBR. I have not seen a file this does not
work for yet. Eventually it would be nice to have more accurate calculation, but that will require we read the entire file.
closes #412