Implement RPC23 #266
Merged
Implement RPC23 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements 'Avoid using Enumerable.Contains on HashSet<string>' analyzer
jaredpar
reviewed
Jan 17, 2024
src/ErrorProne.NET.CoreAnalyzers/CoreAnalyzers/SetContainsAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/ErrorProne.NET.CoreAnalyzers/CoreAnalyzers/SetContainsAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/ErrorProne.NET.CoreAnalyzers/CoreAnalyzers/SetContainsAnalyzer.cs
Outdated
Show resolved
Hide resolved
…yzer.cs Co-authored-by: Jared Parsons <jared@paranoidcoding.org>
Youssef1313
reviewed
Jan 20, 2024
| // and the second one that takes StringComparer, | ||
| // and only the second one is linear. | ||
| methodSymbol.Parameters.Length == 3 && | ||
| methodSymbol.ContainingType.IsClrType(compilation, typeof(System.Linq.Enumerable)); |
There was a problem hiding this comment.
@SergeyTeplyakov I came across this PR from Twitter. I think this has performance implications as it will cause compilation.GetTypeByMetadataName to be called multiple times.
Generally, the needed symbols should be retrieved first in a compilation start action, then do symbol comparison in the operation action here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements 'Avoid using Enumerable.Contains on HashSet' analyzer.
Here is an example: