Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel/RTL8168: Change invalid u32 mmio reads to u8 #25651

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

RatcheT2497
Copy link
Contributor

Crash caused by erroneous reading of a few 8bit registers as 32bit, which then asserts.
This PR allows the OS to boot on a Lenovo Ideapad 700!

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 15, 2025
Copy link
Member

@spholz spholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, otherwise LGTM!

From CONTRIBUTING.md:

Don't:
Use weasel-words like "refactor" or "fix" to avoid explaining what's being changed.

Crash caused by erroneous reading of a few 8bit registers as 32bit,
causing an unaligned access panic.
@RatcheT2497 RatcheT2497 force-pushed the rtl8168_wrongsize_read_fix branch from e43c8dc to f3f36b8 Compare January 16, 2025 00:09
@RatcheT2497 RatcheT2497 changed the title Kernel/Net: Fix kernel panic on hardware using the RTL8168 driver Kernel/4 Jan 16, 2025
@RatcheT2497 RatcheT2497 changed the title Kernel/4 Kernel/RTL8168: Change invalid 32bit mmio reads to u8 Jan 16, 2025
@RatcheT2497 RatcheT2497 changed the title Kernel/RTL8168: Change invalid 32bit mmio reads to u8 Kernel/RTL8168: Change invalid u32 mmio reads to u8 Jan 16, 2025
@nico nico merged commit 62a25aa into SerenityOS:master Jan 16, 2025
15 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants