Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AK: Array and Tuple structured bindings #24993

Closed
wants to merge 5 commits into from

Conversation

nrdmn
Copy link

@nrdmn nrdmn commented Sep 3, 2024

This PR allows Array and Tuple to be used in structured binding declarations.

This is a new copy of #24986 because apparently I can't re-open closed PRs.

@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Sep 3, 2024
This ensures that the result of calling get() on a temporary Tuple
cannot be assigned to a lvalue reference.
@DanShaders
Copy link
Contributor

Welcome to the project!

Do you have a use-case for these changes? We generally don't add library features for the case of adding features. Also note that the consensus is (or, at least, was) to prefer dedicated structures over tuples for situations that might require convenient unpacking. See a relatively recent discussion on Discord around this message.

Copy link

stale bot commented Sep 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Sep 28, 2024
Copy link

stale bot commented Oct 5, 2024

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this Oct 5, 2024
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants