LibJS+LibWeb: Fix crashy regressions on shopify.com and polar.sh #21967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
awesomekling
force-pushed
the
uncrash-shopify-and-polar
branch
2 times, most recently
from
4fe2579
to
6494828
Compare
This is what the specification tells us to do: https://tc39.es/ecma262/#cyclic-module-record Co-Authored-By: networkException <networkexception@serenityos.org>
This allows them to participate in the ownership graph and fixes a lifetime issue in module loading found by ASAN. Co-Authored-By: networkException <networkexception@serenityos.org>
This makes assertion failures here more informative.
This breaks module loading temporarily while transitioning.
In particular, this patch focuses on: - Updating the old "import assertions" to the new "import attributes" - Allowing realms as module import referrer
In particular, this patch removes three host hooks on JS::VM in favor of the new JS-side module loading stuff.
The comment was right, but the code didn't match.
This allows test-js to run all the module tests in the new world.
We were previously updating a copy of the list, which meant loading could not proceed even after a module was loaded.
This ensures that repeated loads of the same module succeed. (There is a specific criteria where the same exact module object has to be returned for multiple loads of the same referrer + specifier.) Note that we don't check the referrer at the moment, that's a FIXME.
I'm not entirely sure why this is needed, but it's the same ol' workaround we're using in a bazillion places where we get caught trying to do JavaScripty things without a running execution context.
In both cases, related to fetching/loading modules.
awesomekling
force-pushed
the
uncrash-shopify-and-polar
branch
from
6494828
to
b773981
Compare
github-actions
bot
added
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bugfix from @networkException for
JS::CyclicModuleand some GC lifetime fixes for module loading.Fixes #21899
Fixes #21737