Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the games on the date the games ended. #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jpyllman
Copy link

Add the option -p/--page to select page to start at.

In the API call to OGS it now have ordering=ended. This makes the games come in the same order every time.

And the -p option makes it possible to start download at a specific page. This makes is possible to later only download games that are newer.

Add the option -p/--page to select page to start at.
@Serene-Arc
Copy link
Owner

What is the benefit to doing this? I ask because it would add a crude filter mechanism, but would it be more useful to add a proper filtering mechanism instead? Pagination feels like something best abstracted away from the user, but things like title regex, participant regex, date ranges, etc, would be probably be quite useful.

@jpyllman
Copy link
Author

The reason I did this was because I wanted to do games where ended > . But I did not get the OGS API to do that. So the closes I came to that was to sort on ended and to start at some specific page.

@jpyllman
Copy link
Author

OK, I will see if I have a 'correct' date filter instead. I agree that pages is not good. So there will most likely be another PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants