-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/history #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/history #36
Conversation
Summary of ChangesHello @IlinJoy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses several issues related to the history feature and request processing. It improves the robustness of variable replacement within API requests by applying it to more parts of the request (headers, body, URL, method). Additionally, it refines how request details are stored in the history, ensuring that the saved data accurately reflects the processed request parameters. A minor fix for locale-aware route generation is also included. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
β Deploy Preview for vatruzhka ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes issues related to history saving and route generation. The changes correctly apply variable substitution to request parts like URL, method, headers, and body before sending the request. It also ensures the correct data (like request body and normalized URL) is saved to the history. The route generation is made more robust to handle potentially empty locale values.
My main feedback is a suggestion to refactor a piece of logic in src/stores/rest-client/store.ts. While functionally correct, the current implementation for creating the history entry and setting the response state is a bit convoluted. A small refactoring could significantly improve the code's readability and maintainability.
Type of PR π©
Changes Introduced π₯―
Self-Check β