Skip to content

Conversation

@Sepulator
Copy link
Owner

Type of PR 🍩

  • Feature
  • Bugfix
  • Hotfix
  • Refactoring
  • Documentation
  • Infrastructure

Changes Introduced 🥯

  • Refactored:
    • additional tests

Self-Check ✅

  • No console errors (except API requests)
  • 80%+ test coverage
  • Documentation updated (if relevant)
  • Package.json scripts updated (if relevant)

@netlify
Copy link

netlify bot commented Sep 21, 2025

Deploy Preview for vatruzhka ready!

Name Link
🔨 Latest commit bcd7900
🔍 Latest deploy log https://app.netlify.com/projects/vatruzhka/deploys/68d067731bfbe50008e386c1
😎 Deploy Preview https://deploy-preview-33--vatruzhka.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Sepulator, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant enhancement to the application's testing infrastructure, primarily by introducing comprehensive unit tests for various page components. The goal is to achieve higher code coverage and improve the overall reliability and maintainability of the codebase. It also includes minor adjustments to ESLint rules and error handling for better development practices.

Highlights

  • Expanded Test Coverage: New test files have been added for several key page components, including LoginPage, SignUpPage, HomePage, RootLayout, and GlobalNotFound, significantly increasing the test coverage for the src/app directory.
  • Updated Vitest Configuration: The vitest.config.ts file has been modified to remove src/app from the coverage exclusion list, ensuring that these new page tests contribute to the overall code coverage metrics.
  • Enhanced Testing Utilities: Global mocks for next/navigation and next/headers have been introduced in src/testing/setup-tests.ts, providing a more robust and consistent testing environment for Next.js-specific functionalities.
  • ESLint Rule Adjustment: The no-empty ESLint rule has been changed from off to warn in eslint.config.mjs, promoting better code quality by flagging empty blocks.
  • Improved Supabase Error Handling: Error logging has been added to the catch block within the Supabase client's cookie handling in src/utils/supabase/server.ts, making it easier to diagnose issues related to cookie operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a number of tests for pages to increase code coverage, which is a great initiative. I've reviewed the new test files and found several areas for improvement. My feedback focuses on correcting test assertions, improving test structure by removing code duplication with beforeEach hooks, and fixing a problematic module mock that conflicts with the global test setup. These changes will make the tests more robust, maintainable, and accurate.

Comment on lines +30 to +34
it('handles empty children', () => {
const { container } = render(<RootLayout>{null}</RootLayout>);

expect(container).toBeInTheDocument();
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The assertion expect(container).toBeInTheDocument() is not very meaningful as it will always pass for a rendered component. To make this test more robust, you should assert that the container has no child nodes when null is passed as children.

Suggested change
it('handles empty children', () => {
const { container } = render(<RootLayout>{null}</RootLayout>);
expect(container).toBeInTheDocument();
});
it('handles empty children', () => {
const { container } = render(<RootLayout>{null}</RootLayout>);
expect(container.firstChild).toBeNull();
});

@Sepulator Sepulator changed the title test: pages tests to achive code coverage test: code coverage Sep 21, 2025
@github-actions github-actions bot requested a review from IlinJoy September 21, 2025 21:00
@Sepulator Sepulator merged commit a7e465c into develop Sep 21, 2025
6 checks passed
@Sepulator Sepulator deleted the tests/code-coverage branch September 21, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants