Chore/pr template and linting improvement #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlinJoy
approved these changes
Sep 3, 2025
| @@ -0,0 +1,23 @@ | |||
| # Type of PR 🍩 | |||
Collaborator
There was a problem hiding this comment.
Definitely like our PR headings😍
.github/pull_request_template.md
Outdated
|
|
||
| - [ ] No console errors (except API requests) | ||
| - [ ] 80%+ test coverage | ||
| - [ ] Reviewers have been requested |
Collaborator
There was a problem hiding this comment.
Mey be it would be better to remove this checkbox since we automated this action
Collaborator
Author
There was a problem hiding this comment.
Just to clarify - which checkbox exactly did you mean?
Collaborator
There was a problem hiding this comment.
'Reviewers have been requested'-this one
Collaborator
Author
There was a problem hiding this comment.
Thanks! It's updated
Collaborator
There was a problem hiding this comment.
A huge amount of work has been done here, nice!
Sepulator
approved these changes
Sep 4, 2025
Owner
Sepulator
left a comment
Sepulator
left a comment
There was a problem hiding this comment.
My appreciate of detailed eslint rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR 🍩
Changes Introduced 🥯
Self-Check ✅