forked from apache/carbondata
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CACRBONDATA-317] CSV having only space char is throwing NullPointer.…
… This closes apache#237
- Loading branch information
Showing
3 changed files
with
74 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
integration/spark/src/test/resources/emptyrow/csvwithonlyspacechar.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
68 changes: 68 additions & 0 deletions
68
...g/apache/carbondata/integration/spark/testsuite/emptyrow/TestCSVHavingOnlySpaceChar.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.carbondata.integration.spark.testsuite.emptyrow | ||
|
||
import java.io.File | ||
|
||
import org.apache.spark.sql.common.util.CarbonHiveContext._ | ||
import org.apache.spark.sql.common.util.QueryTest | ||
import org.scalatest.BeforeAndAfterAll | ||
|
||
import org.apache.carbondata.core.constants.CarbonCommonConstants | ||
import org.apache.carbondata.core.util.CarbonProperties | ||
|
||
class TestCSVHavingOnlySpaceChar extends QueryTest with BeforeAndAfterAll { | ||
|
||
var csvFilePath : String = null | ||
|
||
override def beforeAll { | ||
sql("drop table if exists emptyRowCarbonTable") | ||
//eid,ename,sal,presal,comm,deptno,Desc | ||
sql( | ||
"create table if not exists emptyRowCarbonTable (eid int,ename String,sal decimal,presal " + | ||
"decimal,comm decimal" + | ||
"(37,37),deptno decimal(18,2),Desc String) STORED BY 'org.apache.carbondata.format'" | ||
) | ||
CarbonProperties.getInstance() | ||
.addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "yyyy/mm/dd") | ||
val currentDirectory = new File(this.getClass.getResource("/").getPath + "/../../") | ||
.getCanonicalPath | ||
csvFilePath = currentDirectory + "/src/test/resources/emptyrow/csvwithonlyspacechar.csv" | ||
} | ||
|
||
|
||
test("dataload") { | ||
try { | ||
sql( | ||
s"""LOAD DATA INPATH '$csvFilePath' INTO table emptyRowCarbonTable OPTIONS('DELIMITER'=',','QUOTECHAR'='"')""") | ||
} catch { | ||
case e: Throwable => | ||
System.out.println(e.getMessage) | ||
assert(e.getMessage.contains("First line of the csv is not valid.")) | ||
} | ||
} | ||
|
||
override def afterAll { | ||
sql("drop table emptyRowCarbonTable") | ||
sql("drop table emptyRowHiveTable") | ||
CarbonProperties.getInstance() | ||
.addProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT, "dd-MM-yyyy") | ||
} | ||
} |