Skip to content

Commit

Permalink
clean code
Browse files Browse the repository at this point in the history
  • Loading branch information
QiangCai committed Apr 7, 2017
1 parent 33544d3 commit 6c73d88
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 12 deletions.
2 changes: 1 addition & 1 deletion assembly/src/main/assembly/assembly.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<dependencySets>
<dependencySet>
<includes>
<include>org.huawei.datasight:*:jar</include>
<include>org.apache.carbondata:*:jar</include>
</includes>
</dependencySet>
<dependencySet>
Expand Down
7 changes: 2 additions & 5 deletions common/src/test/java/log4j.properties
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
log4j.logger.com.huawei=INFO,R5
log4j.logger.org.apache.carbondata=INFO,R5
log4j.appender.R5=org.apache.carbondata.common.logging.impl.AuditExtendedRollingFileAppender
log4j.appender.R5.File=./unibiaudit.log
log4j.appender.R5.File=./carbondataaudit.log
log4j.appender.R5.threshold=AUDIT#org.apache.carbondata.common.logging.AuditLevel
log4j.appender.R5.layout=org.apache.log4j.PatternLayout
log4j.appender.R5.layout.ConversionPattern=%d [%t] %p [%c] %X{CLIENT_IP} %X{USER_NAME} %X{MODULE} %X{OPERATRION}- %m%n



Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ public class LoggingServiceTest_FT extends TestCase {
@Test public void testAudit() {

String expectedAuditLine =
"[main] AUDIT [com.huawei.iweb.platform.logging.ft.LoggingServiceTest_FT] 127.0.0.1 "
"[main] AUDIT [org.apache.carbondata.common.logging.ft.LoggingServiceTest_FT] 127.0.0.1 "
+ "testuser Function Test log- audit message created";
logger.audit("audit message created");

LogManager.shutdown();

try {
FileInputStream fstream = new FileInputStream("./unibiaudit.log");
FileInputStream fstream = new FileInputStream("./carbondataaudit.log");
BufferedReader br = new BufferedReader(new InputStreamReader(fstream));
String actualAuditLine = null;
String strLine = null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public abstract class AbstractBTreeBuilder implements BtreeBuilder {

public AbstractBTreeBuilder() {
maxNumberOfEntriesInNonLeafNodes = Integer.parseInt(CarbonProperties.getInstance()
.getProperty("com.huawei.datastore.internalnodesize",
.getProperty("org.apache.carbondata.core.datastore.internalnodesize",
DEFAULT_NUMBER_OF_ENTRIES_NONLEAF + ""));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ public AtomicFileOperationsImpl(String filePath, FileType fileType) {

}

/* (non-Javadoc)
* @see com.huawei.unibi.carbon.datastorage.store.fileperations.AtomicFileOperations#close()
*/
@Override public void close() throws IOException {

if (null != dataOutStream) {
Expand Down

0 comments on commit 6c73d88

Please sign in to comment.