Skip to content

Typescript refactor #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarterSolberg merged 264 commits into from
Feb 15, 2023
Merged

Typescript refactor #101

CarterSolberg merged 264 commits into from
Feb 15, 2023

Conversation

@CarterSolberg
Copy link
Collaborator

@CarterSolberg CarterSolberg commented Feb 1, 2023 •
edited
Loading

Typescript Refactor

Description

  • Massive update with lots of under the hood changes.
  • Added a toolbox item for changing annotation color.
  • Added a toolbox item for changing annotation size.
  • Added a toolbox item for filtering out annotations based on annotation confidence.
  • Added support for adding diffrent Submit buttons, such as a Reject button or Failure button.
  • Added a display for annotation's confidence on hover.
  • Added keybinds for most operations.

Also Closes #45

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

This very well may break something. This pr contains all of the changes from the past ~8 months where we went added a lot of features and refactored much of the code.

joshua-dean and others added 30 commits February 1, 2022 13:37
@joshua-dean
Format index.js
512c8fc
@joshua-dean
Implemented a redraw update call for ToolboxItems
e5ecc3b
@CarterSolberg
Added annotation resize item
2e91b4c
@CarterSolberg
added redraw
f3474e5
@CarterSolberg
updated switch in resize annotations
c8c2d76
@joshua-dean
Auto CLRF test.
2d0f180
@joshua-dean
Fixed for loops for annotation resizing.
e25c534
@joshua-dean
Fixed case statement fallthrough.
b1eebca
@CarterSolberg
added css for annotation resize
7006ee6
@joshua-dean
Fixed div referencing in blob.js
760d5bd
@CarterSolberg
Added CSS
6e1fe24
@CarterSolberg
added missing " in annotation-resize tb-header, and added test p to a…
d3e7ddb 
…nnotation resize
@CarterSolberg
Added css for annotation-resize
48a9b8c
@joshua-dean
Added gitattributes file.
55cc6ee
@joshua-dean
Fix line endings.
7cf1e0e
@joshua-dean
Merge pull request #52 from csolbs24/annotation-resize-tbi
3b39db1 
Annotation resize tbi
@CarterSolberg
Started adding the annotation recolorer
3c04c0f
@CarterSolberg
Finished adding point size and color toolbox items
5d2859f
@CarterSolberg
Added visual indication of when vanish mode is toggled
f5b1bb4
@CarterSolberg
Fixed + and - buttons size in change annotation size
dc37b7f
@CarterSolberg
Added Keypoint Slider toolbox item, and a slider inside of it
97a1309
@CarterSolberg
annotation line size can no longer go negative
b8f1976
@CarterSolberg
fixed spelling of cached_size
a8bd1e2
@CarterSolberg
Added the get_annotation_confidence function to index.js to be used a…
5e06885 
…s a callback function
@CarterSolberg
Keypoint slider filters through the annotations and sets all annotati…
03a944a 
…ons with confidence less than the value on the slider to deprecated
@CarterSolberg
Merge pull request #54 from csolbs24/annotation-color
72a725d 
Annotation color
@CarterSolberg
Added functions to draw to canvas to create histogram
e1ee4f8
@CarterSolberg
Merge branch 'typescript-refactor' into keypoint-slider
458531e
@CarterSolberg
Added keypoint slider toolbox item
710249b
@CarterSolberg
Merge branch 'typescript-refactor' into keypoint-slider
16a5083
@CarterSolberg CarterSolberg added bug Something isn't working enhancement New feature or request refactor The code should be better labels Feb 1, 2023
TrevorBurgoyne
TrevorBurgoyne reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly suggested cleaning up some comments, imo if we want to resurrect the commented out functionality we can look back at a previous version, up to you tho. Overall the seperation into different files and the ts reworking seems very nice. It would be a lot more work but could be nice to add more detailed function helpers to those functions that still don't have them. Overall a nice chonky pr 👍

CarterSolberg and others added 2 commits February 2, 2023 17:24
@CarterSolberg @TrevorBurgoyne
Remove commented out code
088df40 
Co-authored-by: Trevor Burgoyne <82477095+TrevorBurgoyne@users.noreply.github.com>
@CarterSolberg @TrevorBurgoyne
Remove more commented out code
c3aeb0d 
Co-Authored-By: Trevor Burgoyne <82477095+TrevorBurgoyne@users.noreply.github.com>
@CarterSolberg
Copy link
Collaborator Author

CarterSolberg commented Feb 2, 2023

It would be a lot more work but could be nice to add more detailed function helpers to those functions that still don't have them.

Yeah I think that's the plan, but for now we'll wait to do that for another refactoring passthrough. This pr is way too chonky as it is.

@CarterSolberg @TrevorBurgoyne
Remove ULabel's dependency on itself
d0bb942 
Co-Authored-By: Trevor Burgoyne <82477095+TrevorBurgoyne@users.noreply.github.com>
TrevorBurgoyne
TrevorBurgoyne approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

joshua-dean
joshua-dean reviewed Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@joshua-dean joshua-dean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few semantic changes suggested, but otherwise this looks pretty slick overall

CarterSolberg and others added 2 commits February 9, 2023 15:18
@CarterSolberg @joshua-dean
Update comments
11d7da0 
Co-authored-by: Joshua Dean <joshua.dean@sentera.com>
@CarterSolberg
Move VALID_HTML_COLORS to its own file
c093011
joshua-dean
joshua-dean approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@joshua-dean joshua-dean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@CarterSolberg CarterSolberg merged commit 05bbe6c into main Feb 15, 2023
@joshua-dean joshua-dean mentioned this pull request Sep 27, 2024
Closed
@TrevorBurgoyne TrevorBurgoyne deleted the typescript-refactor branch September 27, 2024 17:17
@joshua-dean joshua-dean mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshua-dean joshua-dean joshua-dean approved these changes

@TrevorBurgoyne TrevorBurgoyne TrevorBurgoyne approved these changes

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request refactor The code should be better

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keyboard shortcut request

4 participants

@CarterSolberg @joshua-dean @TrevorBurgoyne