2023-01-22 Pi-hole admin password changes - experimental branch - PR 3 of 3 #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3 of 3 See SensorsIot#648 for background to this PR. Consequential changes: * harmonises template service definition by removing reference to port 443 and re-aligning entries. * harmonises default environment variables to be the same as master branch (including comments). * removes obsolete `networks:` clause. * removes handling for `TZ`, `WEBPASSWORD`, `DNS1` and `DNS2` from the modifiable environment. The DNS pair are a consequence of overall harmonisation. Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Paraphraser
changed the title
Slyke
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…3 of 3
See #648 for background to this PR.
Consequential changes:
networks:clause.TZ,WEBPASSWORD,DNS1andDNS2from the modifiable environment. The DNS pair are a consequence of overall harmonisation.Signed-off-by: Phill Kelley 34226495+Paraphraser@users.noreply.github.com