added permissions for BLUETOOTH and BLUETOOTH_ADMIN

[crayne]

Added permissions to AndroidManifest.xml because SensingKit build failed without them.

[minoskt]

Hi Susan

Many thanks for your contribution. It is correct that the two permissions are required when using the Bluetooth sensor. However it is better if the two permissions are defined in the AndroidManifest.xml of the actual app (that encapsulates the library) instead of the library's one. With that way, apps that utilise SensingKit but do not use that specific sensor would not request access to Bluetooth (e.g. "This app has access to: Bluetooth" when installing the app).

Same applies to other permissions like RECORD_AUDIO for the Audio Recorder or the Audio Level sensor.

I agree that it is confusing and should be explained in the documentation.

Best regards
Minos

[crayne]

Hi Minos
Thank you for pointing this out.  What you said makes a lot of sense. I had thought that the build failure was a fatal error, which is why I added the permissions.  In fact, the libraries were built, so no change to the manifest file was necessary. I have closed the pull request.
Susan

  From: Minos Katevas <notifications@github.com>

To: SensingKit/SensingKit-Android SensingKit-Android@noreply.github.com
Cc: Susan Crayne susancrayne@yahoo.com
Sent: Friday, December 18, 2015 9:05 AM
Subject: Re: [SensingKit-Android] added permissions for BLUETOOTH and BLUETOOTH_ADMIN (#3)

Hi SusanMany thanks for your contribution. It is correct that the two permissions are required when using the Bluetooth sensor. However it is better if the two permissions are defined in the AndroidManifest.xml of the actual app (that encapsulates the library) instead of the library's one. With that way, apps that utilise SensingKit but do not use that specific sensor would not request access to Bluetooth (e.g. "This app has access to: Bluetooth" when installing the app).Same applies to other permissions like RECORD_AUDIO for the Audio Recorder or the Audio Level sensor.I agree that it is confusing and should be explained in the documentation.Best regards
Minos—
Reply to this email directly or view it on GitHub.