Fix: Deprecated supported features values #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golles
commented
Jan 4, 2024
Comment on lines
-5
to
-11
|
|
||
| import logging | ||
| from itertools import chain | ||
|
|
||
| from homeassistant.const import MATCH_ALL | ||
|
|
||
| _LOGGER = logging.getLogger(__name__) |
There was a problem hiding this comment.
This file wasn't doing anything, so I've removed the content
golles
commented
Jan 4, 2024
Comment on lines
+1
to
+4
| """ | ||
| Template for media-player | ||
| https://github.com/Sennevds/media_player.template | ||
| """ |
There was a problem hiding this comment.
The old description seemed to be copied from somewhere else, I assumed you would like the same description as in __init__.py
golles
commented
Jan 4, 2024
| await self._mute_script.async_run( | ||
| {"is_muted": mute}, context=self._context | ||
| ) | ||
| await self._mute_script.async_run({"is_muted": mute}, context=self._context) |
There was a problem hiding this comment.
prettier has formatted it like this
golles
commented
Jan 4, 2024
| @@ -742,7 +721,7 @@ def sound_mode(self): | |||
| """Return the current input source.""" | |||
| try: | |||
| if self._current_sound_mode_template is not None: | |||
| self._curre = self._current_sound_mode_template.async_render() | |||
| self._sound_mode = self._current_sound_mode_template.async_render() | |||
There was a problem hiding this comment.
@Sennevds please double check this, it looked like something was broken here
golles
commented
Jan 4, 2024
| @@ -150,14 +131,14 @@ | |||
|
|
|||
|
|
|||
| async def async_setup_platform(hass, config, async_add_entities, discovery_info=None): | |||
| """Set up the template binary sensors.""" | |||
| """Set up platform.""" | |||
golles
commented
Jan 4, 2024
|
|
||
| await async_setup_reload_service(hass, DOMAIN, PLATFORMS) | ||
| async_add_entities(await _async_create_entities(hass, config)) | ||
|
|
||
|
|
||
| async def _async_create_entities(hass, config): | ||
| """Set up the Template switch.""" | ||
| """Set up entities.""" |
golles
commented
Jan 4, 2024
| @@ -97,7 +79,6 @@ | |||
| MEDIA_DURATION_TEMPLATE = "media_duration_template" | |||
| CURRENT_SOUND_MODE_TEMPLATE = "current_sound_mode_template" | |||
| CONF_SOUND_MODES = "sound_modes" | |||
| CONF_UNIQUE_ID = "unique_id" | |||
There was a problem hiding this comment.
I removed this and replaced it with an import (added line 29, see https://github.com/golles/media_player.template/blob/fix-for-%2347/custom_components/media_player_template/media_player.py#L29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #47
I've tested my changes locally using: https://github.com/golles/Home-Assistant-Config/blob/main/packages/media_players/mediabox_homelkit.yaml
I've also set up a local dev container to apply the changes there and test from there
It would be good if more people could test it, as there are no automated tests.
I'll provide some inline comments on what I did.
Let me know your feedback