Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change-to-github-api #19

Merged
merged 21 commits into from
Aug 31, 2022
Merged

Change-to-github-api #19

merged 21 commits into from
Aug 31, 2022

Conversation

SenexCrenshaw
Copy link
Owner

No description provided.

cnorton-webdev and others added 13 commits August 21, 2022 12:23
Format the base_ts.ts file and change declarations of arrays and objects to use [] and {} instead of using new array and new object.

Add ability for channels to be moved to an already occupied channel number. This will shift the channel that previously occupied that channel number and all other channels after up by one number until either an empty channel number is found or the end of the channels is reached. Allows the ability to easily move channels around without the need of manually renumbering channels.
Fixes login page not submitting when pressing enter, also centered the login button.

Added checkbox for new shift channel feature that is on by default. Unchecking the box reverts the mapping to the old method.

Removed "(Emby only)" from kids category as this category is now supported in Plex as well.
Add the ability to search Tapiosinn's tv-logo repository and easily select a TV channel logo to use from the list.

Added the ability to preview a TV channel logo URL so when selecting an image from the list or pasting one in it will show a preview of the image.

Some general linter cleanup as well as added a default TV channel logo to be used if one does not exist and added 2 scripts one for powershell and one for bash to easily generate the webUI.go file from the html folder for development.
Add the ability to search Tapiosinn's tv-logo repository and easily select a TV channel logo to use from the list.

Added the ability to preview a TV channel logo URL so when selecting an image from the list or pasting one in it will show a preview of the image.

Some general linter cleanup as well as added a default TV channel logo to be used if one does not exist and added 2 scripts one for powershell and one for bash to easily generate the webUI.go file from the html folder for development.
Fixes HostIP and HostName not properly being used and set for m3u and xepg file creation.
On Windows machines if buffer to memory is active and the xTeVe cache is set to a folder on a volume other than C: it will cause a panic error and the stream not to play.

This fixes that by checking if we are on Windows and if so is the cache folder path not on the C: volume, if not create the volume it is located on in the memory virtual file system.
@cnorton-webdev
Copy link
Contributor

@SenexCrenshaw nice, I wasn't aware you could use the GitHub API without a token to list all the files in a repository, but that makes it much cleaner and easier to iterate over. 👍🏼

@cnorton-webdev
Copy link
Contributor

In regards to:

Excellent! I have a few suggestions

  1. An option to prefer M3U logos if they are set
  2. Logo URL in the interface. Wasn't obvious I could remove the existing text and type to complete. It works great, just didn't seem obvious. Maybe note "Logo URL: URL or type to search" ... something like that
  3. The ability to search by country. Maybe a pull down list of countries at the top of the mapping page which would be added to the autocomplete filter
  4. The logo json creator is slow. I had another PR I was playing with that downloads using the GitHub API. Maybe you can incorporate this:
    logo.go
  5. func ignoredFiles. I think this can be cleaned up as well
  6. Maybe a filter in the mapping page for missing Logos only?

Thanks for a great PR. Let me know your thoughts.

Sounds good, will look into getting these implemented, thanks for the feedback.

@SenexCrenshaw
Copy link
Owner Author

I am just about done those few items above. You can check out the PR to see where it is going

Cleaned Up logo json to reduce size
Changed WS to allow more than one request
Log logos with 404 or no value
Changed bad logos to use default logo
Added in country selector in settings for logo selection
Ability to Upload M3U/XML files from desktop
@SenexCrenshaw SenexCrenshaw merged commit 1c9c86f into main Aug 31, 2022
@SenexCrenshaw SenexCrenshaw deleted the Change-to-github-api branch August 31, 2022 20:49
@SenexCrenshaw
Copy link
Owner Author

Should be good to go now
/releases/v.2.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants