Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete indexing in Parser #3416

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Autocomplete indexing in Parser #3416

merged 1 commit into from
Apr 7, 2022

Conversation

RC-Lee
Copy link
Contributor

@RC-Lee RC-Lee commented Apr 6, 2022

extension of #3301

Type of Change

moves autocomplete indexing to Parser

Steps to test the PR

 rm -rf redis-data
 docker-compose --env-file ./config/env.development up --build redis elasticsearch posts traefik search nginx planet parser

I am not sure if staging still runs the backend and if it will affect indexing on staging.

@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2022

manekenpix
manekenpix approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@manekenpix manekenpix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After indexing using the parser service (no pnpm start)

image

@TueeNguyen TueeNguyen self-requested a review April 7, 2022 12:38
@Kevan-Y Kevan-Y self-requested a review April 7, 2022 13:28
@TueeNguyen TueeNguyen added this to the 3.0-alpha Release milestone Apr 7, 2022
Kevan-Y
Kevan-Y approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@Kevan-Y Kevan-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TueeNguyen
TueeNguyen approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@TueeNguyen TueeNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested, it works, thanks for the detailed explanation

@RC-Lee RC-Lee merged commit e06b322 into Seneca-CDOT:master Apr 7, 2022
@RC-Lee RC-Lee deleted the autocomplete-parser branch April 7, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekenpix manekenpix manekenpix approved these changes

@Kevan-Y Kevan-Y Kevan-Y approved these changes

@TueeNguyen TueeNguyen TueeNguyen approved these changes

Assignees

@RC-Lee RC-Lee

Labels
None yet
Projects
None yet
Milestone
3.0-alpha Release
Development

Successfully merging this pull request may close these issues.
4 participants
@RC-Lee @manekenpix @Kevan-Y @TueeNguyen