Fix CSP issue and API status in dashboard #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryHue
added
the
area: dashboard
|
|
Andrewnt219
approved these changes
Feb 6, 2022
DukeManh
approved these changes
Feb 6, 2022
humphd
approved these changes
Feb 6, 2022
| @@ -35,7 +35,7 @@ services: | |||
| # Specify the status service port | |||
| - 'traefik.http.services.status.loadbalancer.server.port=${STATUS_PORT}' | |||
| # Define redirect middleware for any requests to /v1/status -> /v1/status/ (trailing slash) | |||
| - 'traefik.http.middlewares.status_redirect.redirectregex.regex=(^.*\/status$$)' | |||
| - 'traefik.http.middlewares.status_redirect.redirectregex.regex=(^.*\/[^status]+\/status$$)' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #2511
Type of Change
Description
There are two CSP-related issues that the PR addresses.
script-srcrule violation. This is due to theonclickhandlers written right into the HTML. This was done by the Material UI template. Since there were of no use, they were removed.connect-srcrule violation. This is due to the redirection when requesting the statuses of the APIs, the redirection would slightly change the protocol fromhttpstohttp, violating the rule. To avoid redirection, we tighten the regex used to trigger this redirection bytraefik.Steps to test the PR
pnpm install)statusservice (pnpm run services:start status)Checklist