Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete to search for Authors #1260 #1385

Closed
wants to merge 5 commits into from

Conversation

MSTEWARDSON
Copy link
Contributor

Issue This PR Addresses

Fixes #1260

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

I didn't realize my code was out of date, so its now updated. I reworked the Autocomplete component into a datalist since there was some conflicts with getting it too work.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@MSTEWARDSON
Copy link
Contributor Author

@humphd Ok, so far I have the autocomplete functionality working with the search-bar, but with only test data atm. I'm unsure on how to make a call to backend to acquire the sites author data for this case, does anyone have any suggestions for this?

@c3ho
Copy link
Contributor

c3ho commented Nov 17, 2020

check /src/backend/web/routes/ for a list of the routes we have, you should be able to publicly access most of them except for the ones that have protectAdmin()

@MSTEWARDSON
Copy link
Contributor Author

@c3ho Alright thank you Ill look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add autocomplete to search for Authors
2 participants