Skip to content

Refactor Query Report Configuration UI and Multi-Select Rendering - #287

Open
ruzaqiarkan-eng wants to merge 3 commits into
query-report-ui-refactor-13779874236980090168from
query-report-ui-refactor-2734629406753595402
Open

Refactor Query Report Configuration UI and Multi-Select Rendering#287
ruzaqiarkan-eng wants to merge 3 commits into
query-report-ui-refactor-13779874236980090168from
query-report-ui-refactor-2734629406753595402

Conversation

@ruzaqiarkan-eng

Copy link
Copy Markdown
Collaborator

Fixed FlexValueControl vertical cutoff issues for multi-value field types like MultiSelectList, improved option resolutions, added support for custom get_query filter parsing in ComboBoxControl, and introduced a complete frappe.query_report shim in QueryRecordsConfig to mimic real Frappe/ERPNext reports environment.


PR created automatically by Jules for task 2734629406753595402 started by @ruzaqiarkan-eng

…rove Query Report environment compatibility

- Ensure MultiSelectList, MultiSelect, and Table MultiSelect fieldtypes render in multi-select mode in FlexValueControl with auto height and wrap-around badges to prevent clipping.
- Implement comprehensive fallback search using search_link_options in MultiSelectList when get_data is not specified.
- Support filter configuration dictionary objects returned by get_query in ComboBoxControl.
- Expose a fully functional frappe.query_report shim in QueryRecordsConfig supporting get_filter_value, set_filter_value, toggle_filter_display, dynamic filters list access, on_change callbacks, and onload hook execution.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…rove Query Report environment compatibility

- Ensure MultiSelectList, MultiSelect, and Table MultiSelect fieldtypes render in multi-select mode in FlexValueControl with auto height and wrap-around badges to prevent clipping.
- Implement comprehensive fallback search using search_link_options in MultiSelectList when get_data is not specified.
- Support filter configuration dictionary objects returned by get_query in ComboBoxControl.
- Expose a fully functional frappe.query_report shim in QueryRecordsConfig supporting get_filter_value, set_filter_value, toggle_filter_display, dynamic filters list access, on_change callbacks, and onload hook execution.
…rove Query Report environment compatibility

- Ensure MultiSelectList, MultiSelect, and Table MultiSelect fieldtypes render in multi-select mode in FlexValueControl with auto height and wrap-around badges to prevent clipping.
- Implement comprehensive fallback search using search_link_options in MultiSelectList when get_data is not specified.
- Support filter configuration dictionary objects returned by get_query in ComboBoxControl.
- Expose a fully functional frappe.query_report shim in QueryRecordsConfig supporting get_filter_value, set_filter_value, toggle_filter_display, dynamic filters list access, on_change callbacks, and onload hook execution.
- Formatted all codebase files to comply with mirrors-prettier (prettier@2.7.1) pre-commit hook constraints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant