Refactor Query Report UI with FlexValueControl - #286
Open
ruzaqiarkan-eng wants to merge 6 commits into
Open
Conversation
- Deprecated and removed legacy toggle between expression and value. - Replaced custom report filter controls with FlexValueControl. - Added "Fetch Default Values" button to report filters header. - Handled loading and parsing legacy filters into structured objects. - Added robust integration and unit test coverage in Query Records.
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Deprecated and removed legacy toggle between expression and value. - Replaced custom report filter controls with FlexValueControl. - Added "Fetch Default Values" button to report filters header. - Handled loading and parsing legacy filters into structured objects. - Added robust integration and unit test coverage in Query Records. - Formatted modified Python and Vue files to satisfy all pre-commit formatting expectations.
- Deprecated and removed legacy toggle between expression and value. - Replaced custom report filter controls with FlexValueControl. - Added "Fetch Default Values" button to report filters header. - Handled loading and parsing legacy filters into structured objects. - Passed flat/resolved primitive filter values to standard Frappe RPC to avoid AttributeError and TypeError crashes during report execution. - Added robust integration and unit test coverage in Query Records.
… formatting - Deprecated and removed legacy toggle between expression and value. - Replaced custom report filter controls with FlexValueControl. - Added "Fetch Default Values" button to report filters header. - Handled loading and parsing legacy filters into structured objects. - Passed flat/resolved primitive filter values to standard Frappe RPC to avoid AttributeError and TypeError crashes during report execution. - Excluded FlexValueControl nested inputs from global .form-control QRC styles to fix double borders and aligned caret/clear button positions. - Added robust integration and unit test coverage in Query Records.
- Deprecated and removed legacy toggle between expression and value. - Replaced custom report filter controls with FlexValueControl. - Added "Fetch Default Values" button to report filters header. - Handled loading and parsing legacy filters into structured objects. - Passed flat/resolved primitive filter values to standard Frappe RPC to avoid AttributeError and TypeError crashes during report execution. - Excluded FlexValueControl nested inputs from global .form-control QRC styles using :not(.fvc-main-field *) to prevent double borders and incorrect centering/middle icon alignment. - Formatted Python and Vue files perfectly to comply with pre-commit hooks (Ruff format, Prettier). - Added robust integration and unit test coverage in Query Records.
… formatting - Deprecated and removed legacy toggle between expression and value. - Replaced custom report filter controls with FlexValueControl. - Added "Fetch Default Values" button to report filters header. - Handled loading and parsing legacy filters into structured objects. - Passed flat/resolved primitive filter values to standard Frappe RPC to avoid AttributeError and TypeError crashes during report execution. - Fixed get_query and filters in Link fields by providing a complete flat values shim for cur_report and frappe.query_report. - Isolated global CSS overrides in controls.css using :not(.fvc-main-field *) to prevent double borders and centered icons in FlexValueControl inputs. - Formatted Python and Vue files perfectly to comply with pre-commit hooks (Ruff format, Prettier). - Added robust integration and unit test coverage in Query Records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances the Query Report configuration panel by utilizing FlexValueControl and adding a dedicated button to easily fetch default filter values from report definitions. Stored and resolved using the central FlexValue structures on both frontend and backend.
PR created automatically by Jules for task 13779874236980090168 started by @ruzaqiarkan-eng