Skip to content

Stop using removed WikiPage::factory #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2025
Merged

Stop using removed WikiPage::factory #963

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc01f07
Stop using removed WikiPage::factory
JeroenDeDauw Sep 2, 2025
d9a0513
Update MapView.php
malberts Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions formats/filtered/src/View/MapView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use DataValues\Geo\Parsers\LatLongParser;
use Exception;
use MediaWiki\MediaWikiServices;
use SMW\DataValues\PropertyValue;
use SRF\Filtered\ResultItem;

Expand Down Expand Up @@ -294,7 +295,6 @@ private function getMarkerIcons() {
$actualParameters = self::getActualParameters()['map view marker icons'];

foreach ( $actualParameters as $relation ) {

$relation = explode( '=', $relation, 2 );

if ( count( $relation ) === 1 ) {
Expand All @@ -305,7 +305,9 @@ private function getMarkerIcons() {
$icon = $relation[1];
}

$file = \WikiPage::factory( \Title::newFromText( $icon, NS_FILE ) )->getFile();
$file = MediaWikiServices::getInstance()->getWikiPageFactory()->newFromTitle(
\Title::newFromText( $icon, NS_FILE )
)->getFile();

if ( $file->exists() ) {
$ret[$key] = $file->getUrl();
Expand Down