Skip to content

Conversation

@gesinn-it-ilm
Copy link
Contributor

This PR is related to the issue #954.

Currently, when using graphfields=yes, only non-Page properties (e.g., strings, dates) are displayed in the graph node info table.
This PR introduces a new optional parameter graphfieldspages= with the following behavior:

  • When graphfieldspages=no (default):

    • All Page-type properties are rendered as graph nodes (edges), and none appear as node fields.
  • When graphfieldspages=yes:

    • For each Page-type property per node:
      • The first Page property is rendered only as a node (edge), not as a field.
      • Any additional Page properties are rendered only as fields in the node info table, not as separate nodes.

This PR also:

  • Adds a test case to verify the new behavior of graphfieldspages.
  • Updates the CI configuration to use the latest stable version of SMW instead of the dev-master branch.

…ckable Page-type fields in graph

- Modified processResultRow method to handle 'graphfieldspages' parameter
- Added optional inclusion of Page-type values as clickable node fields with links
- Improved clarity and control over graph field display behavior
- Prepared groundwork for better customization of graph output in Semantic Result Formats

Ask ChatGPT
…odes with special chars

- Fixes GraphViz errors and rendering issues related to special characters in node identifiers.
… property as node

- Ensures that when `graphfieldspages` is enabled, only the first Page-type property
  is treated as a graph node, and all subsequent Page-type fields are rendered as
  regular fields in the node table.
@gesinn-it-ilm gesinn-it-ilm self-assigned this Jul 31, 2025
@gesinn-it-ilm gesinn-it-ilm marked this pull request as draft July 31, 2025 10:51
@gesinn-it-ilm gesinn-it-ilm marked this pull request as ready for review July 31, 2025 10:57
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 21.05263% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.23%. Comparing base (6dc5022) to head (777c895).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Graph/GraphPrinter.php 0.00% 70 Missing ⚠️
src/Graph/GraphOptions.php 0.00% 3 Missing ⚠️
src/Graph/GraphNode.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #958      +/-   ##
============================================
- Coverage     46.45%   46.23%   -0.23%     
- Complexity     2326     2361      +35     
============================================
  Files            80       80              
  Lines          9084     9158      +74     
============================================
+ Hits           4220     4234      +14     
- Misses         4864     4924      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gesinn-it-gea gesinn-it-gea merged commit 850d92b into master Aug 4, 2025
5 of 7 checks passed
@gesinn-it-gea gesinn-it-gea deleted the issue-954 branch August 4, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants