-
-
Couldn't load subscription status.
- Fork 82
Update DataTables release notes for 5.0.0 release #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #934 +/- ##
=========================================
Coverage 45.39% 45.39%
Complexity 2326 2326
=========================================
Files 80 80
Lines 9078 9078
=========================================
Hits 4121 4121
Misses 4957 4957 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RELEASE-NOTES.md
Outdated
| * Improved accessibility with `aria-live = "polite"` attribute in DataTable [845](https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/845) (by @robinwiel) | ||
| * Added "show all" to DataTable length [868](https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/868) (by @alistair3149) | ||
| * Fixed various sorting and filter issues [865](https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/865) (by @alistair3149) | ||
| * Fixed template expanision [931](https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/931) (by @thomas-topway-it for ([KM-A](https://km-a.net)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo (expansion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, the only point which is not very clear is this
Fixed missing ParentProperties values
|
@alistair3149 I did some edits, for me it's fine |
|
LGTM, @JeroenDeDauw what do you think? |
Per #928 (comment)
@thomas-topway-it would you be able to review the notes please?
I am new to the project and I am unfamiliar with some of the changes that you made.
It would be awesome if you can take a look.