Skip to content

Conversation

@alistair3149
Copy link
Member

Per #928 (comment)

@thomas-topway-it would you be able to review the notes please?
I am new to the project and I am unfamiliar with some of the changes that you made.
It would be awesome if you can take a look.

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.39%. Comparing base (92e24f3) to head (f0481d6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #934   +/-   ##
=========================================
  Coverage     45.39%   45.39%           
  Complexity     2326     2326           
=========================================
  Files            80       80           
  Lines          9078     9078           
=========================================
  Hits           4121     4121           
  Misses         4957     4957           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RELEASE-NOTES.md Outdated
* Improved accessibility with `aria-live = "polite"` attribute in DataTable [845](https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/845) (by @robinwiel)
* Added "show all" to DataTable length [868](https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/868) (by @alistair3149)
* Fixed various sorting and filter issues [865](https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/865) (by @alistair3149)
* Fixed template expanision [931](https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/931) (by @thomas-topway-it for ([KM-A](https://km-a.net))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (expansion)

Copy link
Contributor

@thomas-topway-it thomas-topway-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the only point which is not very clear is this

Fixed missing ParentProperties values

@thomas-topway-it
Copy link
Contributor

@alistair3149 I did some edits, for me it's fine

@alistair3149
Copy link
Member Author

LGTM, @JeroenDeDauw what do you think?

@JeroenDeDauw JeroenDeDauw merged commit 095035e into master Apr 2, 2025
7 checks passed
@JeroenDeDauw JeroenDeDauw deleted the datatable-readme branch April 2, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants