Skip to content

Conversation

@thomas-topway-it
Copy link
Contributor

@thomas-topway-it thomas-topway-it commented Feb 2, 2025

  • removes parameter defer-each (set default limit to 100 and retrieve all rows until the limit both on page load and via Ajax)
  • redesign client-side cache mechanism to correctly handle non-subsequent pages and to take advantage from the retrieved rows against table page length

(test further before merging)

@codecov
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.52%. Comparing base (b40de8d) to head (425581d).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
formats/datatables/Api.php 0.00% 7 Missing ⚠️
formats/datatables/Hooks.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #904   +/-   ##
=========================================
  Coverage     45.51%   45.52%           
+ Complexity     2320     2319    -1     
=========================================
  Files            80       80           
  Lines          9043     9042    -1     
=========================================
  Hits           4116     4116           
+ Misses         4927     4926    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alistair3149
Copy link
Member

Will look into it after #908

Copy link
Member

@alistair3149 alistair3149 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working locally

@alistair3149 alistair3149 merged commit 996b5de into SemanticMediaWiki:master Feb 26, 2025
6 of 7 checks passed
@thomas-topway-it
Copy link
Contributor Author

@alistair3149 thanks a lot for testing, this was an important update !

thomas-topway-it added a commit that referenced this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants