[Filtered] can't access property "_leaflet_events

[krabina]

Setup

• SMW version: 5.1.0
• SRF version: 5.1.0
• MW version: 1.39.13
• PHP version: 8.2.20
• DB system (MySQL,) version: 8.0.28

Issue

In the filtered format, filters work for tables, but in the same filter the map view does not correctly show/hide entries.

jQuery.Deferred exception: can't access property "_leaflet_events", obj is undefined removeOne@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:542:951
off@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:541:526
_removeIcon@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:612:978
onRemove@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:610:996
removeLayer@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:601:356
removeLayer@/load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=1lhhd:96:748
removeLayer@/load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=1lhhd:98:156
removeLayers@/load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=1lhhd:203:438
[21]</hideRows/</<@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:736:810
manipulateLayers@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:736:952
[21]</hideRows/<@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:736:751
mightThrow@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:790:247
Deferred/then/resolve/</process<@/load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery&skin=chameleon&version=1i14j:790:906
 undefined

Steps to reproduce the observation (recommendation is to use the sandbox):

[thomas-topway-it]

isn't this a duplicate of SemanticMediaWiki/SemanticMediaWiki#6247 ?

[krabina]

yes, but 6247 was in the wrong repo. Clearly a SRF bug.

[kghbln]

I can confirm the issue for

• MediaWiki 1.43.5 (fc5f211)
• PHP 8.1.33 (apache2handler)
• Semantic MediaWiki 6.0.1
• Semantic Result Formats 5.1.0

jquery.js:3783 jQuery.Deferred exception: Cannot read properties of undefined (reading '_leaflet_events') TypeError: Cannot read properties of undefined (reading '_leaflet_events')
    at removeOne (https://zp.pro.wiki/w/load.php?lang=de&modules=dompurify%2Cjquery%2Coojs%2C…ws.icons%7Coojs-ui.styles.indicators&skin=chameleon&version=uhuur:1188:954)
    at off (https://zp.pro.wiki/w/load.php?lang=de&modules=dompurify%2Cjquery%2Coojs%2C…ws.icons%7Coojs-ui.styles.indicators&skin=chameleon&version=uhuur:1187:517)
    at NewClass._removeIcon (https://zp.pro.wiki/w/load.php?lang=de&modules=dompurify%2Cjquery%2Coojs%2C…ws.icons%7Coojs-ui.styles.indicators&skin=chameleon&version=uhuur:1258:975)
    at NewClass.onRemove (https://zp.pro.wiki/w/load.php?lang=de&modules=dompurify%2Cjquery%2Coojs%2C…ws.icons%7Coojs-ui.styles.indicators&skin=chameleon&version=uhuur:1256:996)
    at NewClass.removeLayer (https://zp.pro.wiki/w/load.php?lang=de&modules=dompurify%2Cjquery%2Coojs%2C…ws.icons%7Coojs-ui.styles.indicators&skin=chameleon&version=uhuur:1247:356)
    at NewClass.removeLayer (https://zp.pro.wiki/w/load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=38x0c:96:748)
    at NewClass.removeLayer (https://zp.pro.wiki/w/load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=38x0c:98:156)
    at NewClass.removeLayers (https://zp.pro.wiki/w/load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=38x0c:203:438)
    at https://zp.pro.wiki/w/load.php?lang=de&modules=dompurify%2Cjquery%2Coojs%2C…ws.icons%7Coojs-ui.styles.indicators&skin=chameleon&version=uhuur:1382:810
    at MapView.manipulateLayers (https://zp.pro.wiki/w/load.php?lang=de&modules=dompurify%2Cjquery%2Coojs%2C…ws.icons%7Coojs-ui.styles.indicators&skin=chameleon&version=uhuur:1382:950) undefined

The console output is slightly different from what @krabina posted, but I guess this is due to a different browser being used. I am on Chrome.

Anyhow, the filtered results show arbitrary selections unrelated to the defined selection criteria, rendering them useless.


[thomas-topway-it]

can you check if this #976 fixes this problem ?

[krabina]

It does not. Here is the console output

VM19:20 wat.js loaded
load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:793 jQuery.Deferred exception: Cannot read properties of undefined (reading '_leaflet_events') TypeError: Cannot read properties of undefined (reading '_leaflet_events')
    at removeOne (Benutzer:load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:542:954)
    at off (Benutzer:load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:541:517)
    at NewClass._removeIcon (Benutzer:load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:612:975)
    at NewClass.onRemove (Benutzer:load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:610:996)
    at NewClass.removeLayer (Benutzer:load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:601:356)
    at NewClass.removeLayer (Benutzer:load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=1cyq4:96:748)
    at NewClass.removeLayer (Benutzer:load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=1cyq4:98:156)
    at NewClass.removeLayers (Benutzer:load.php?lang=de&modules=ext.srf.filtered.map-view.leaflet&skin=chameleon&version=1cyq4:203:438)
    at Benutzer:load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:736:810
    at MapView.manipulateLayers (Benutzer:load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:736:950) undefined
(anonymous) @ load.php?lang=de&modules=ext.bootstrap.scripts%7Cext.srf.filtered%7Cjquery%2Coojs-ui-core&skin=chameleon&version=1x8se:793

[thomas-topway-it]

@kghbln do you have any hint to reproduce it ? (like a setup with properties and the precise ask query)

[kghbln]

@thomas-topway-it Regrettably, I cannot test code changes at the moment. The ask query that worked in previous versions:

{{#ask:
 [[Kategorie:Internierungsort]]
 [[Hat Bezeichnung Lager::+]]
 |?Hat Insassen Lager=Insassen |+filter=value |+value filter switches=on off 
 |?Hat Bestandsdauer Lager=Bestandszeitraum
 |?Hat Koordinaten Lager=Koordinaten
 |headers=plain
 |mainlabel=Internierungsort
 |format=filtered   
 |limit=5000
 |filter position=top  
 |views=map=Karte,table=Tabelle
 |map view marker position property=Hat Koordinaten Lager
 |map view marker cluster=false
 |map view marker cluster max zoom=12
 |map view marker icon property=Hat Insassen Lager 
 |map view marker icons=zivile ausländische Arbeiter=MarkerBlue.svg,Kriegsgefangene=MarkerRed.svg,Kriegsgefangene und zivile ausländische Arbeiter=MarkerGreen.svg,nicht genau bekannt=MarkerYellow.svg,MarkerGrey.svg
 |table view class=table table-hover table-condensed table-responsive sortable 
}}

"Hat Insassen Lager" and "Hat Bestandsdauer Lager" are of type Text and "Hat Koordinaten Lager" of type Geographical Coordinates.

[thomas-topway-it]

@kghbln I've tested your query and it works (I did another update to this branch https://github.com/Knowledge-Wiki/SemanticResultFormats/tree/fixfiltered-map ) -- I haven't yet reproduced _leaflet_events

[kghbln]

@thomas-topway-it Thanks a ton for working on this. We could merge here, and I will try to get the change to the respective wiki. We could still revert or improve here before the next release.

[kghbln]

@thomas-topway-it @krabina The fix works for me. Cool and big thanks. Moreover, I do no longer get #974 but

TypeError: can't access property "results", queryContext is undefined
    onSearchSessionEnd resource:///modules/UrlbarProviderGlobalActions.sys.mjs:150
    tryMethod resource:///modules/UrlbarUtils.sys.mjs:2750
    #notifySearchSessionEnd resource:///modules/UrlbarProvidersManager.sys.mjs:491
    notifyEngagementChange resource:///modules/UrlbarProvidersManager.sys.mjs:428
    #internalRecord resource:///modules/UrlbarController.sys.mjs:987
    record resource:///modules/UrlbarController.sys.mjs:883
    handleNavigation resource:///modules/UrlbarInput.sys.mjs:868
    handleCommand resource:///modules/UrlbarInput.sys.mjs:707
    _initPasteAndGo resource:///modules/UrlbarInput.sys.mjs:3720
UrlbarUtils.sys.mjs:2752:15

on Firefox. Chrome was tamed, i.e., no issue in the console.

[thomas-topway-it]

thanks for your feedback. I don't get that error on firefox, it seems something related to the browser's codebase, not ours