Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates to contribution.md #4383

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

carkod
Copy link
Contributor

@carkod carkod commented Sep 27, 2022

Corrected some words, added link to Cypress. In the case of hand written this should be spelled as hand-written or handwritten. See

Corrected some words, added links. In the case of `hand written` this
should be spelled as `hand-written` or `handwritten`. [See](https://ell.stackexchange.com/questions/128289/how-to-spell-correctly-hand-written-or-handwritten#:~:text=Handwritten%20and%20hand%2Dwritten%20are,but%20lost%20that%20in%20years.)
@welcome
Copy link

welcome bot commented Sep 27, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@carkod carkod changed the title chore: corrections chore: contribution.md corrections Sep 27, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 99.75% // Head: 99.75% // No change to project coverage 👍

Coverage data is based on head (7527d17) compared to base (0e1a55a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4383   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         180      180           
  Lines        3248     3248           
=======================================
  Hits         3240     3240           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@layershifter layershifter changed the title chore: contribution.md corrections docs: updates to contribution.md Sep 27, 2022
@layershifter layershifter merged commit 50a521e into Semantic-Org:master Sep 27, 2022
@welcome
Copy link

welcome bot commented Sep 27, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants