-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Ref): restore docs for a component #4039
Conversation
size-limit report
|
Codecov Report
@@ Coverage Diff @@
## master #4039 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 183 183
Lines 3276 3276
=======================================
Hits 3271 3271
Misses 5 5
Continue to review full report at Codecov.
|
repoPath={componentInfo.repoPath} | ||
type={componentInfo.type} | ||
/> | ||
{componentInfo.repoPath && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -31,7 +31,7 @@ class ReferenceProxy { | |||
* @see https://popper.js.org/popper-documentation.html#referenceObject | |||
*/ | |||
const createReferenceProxy = _.memoize( | |||
(reference) => new ReferenceProxy(isRefObject(reference) ? reference : toRefObject(reference)), | |||
(reference) => new ReferenceProxy(isRefObject(reference) ? reference : { current: reference }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small follow up fix for #4023.
component: 'docs/src/components/ComponentDoc', | ||
priority: 0.8, | ||
getData: async () => { | ||
const componentsInfo = getComponentGroupInfo(baseInfo.displayName) | ||
const sidebarSections = getSidebarSections(baseInfo.displayName) | ||
const componentsInfo = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's annoying to do this manually, but in any case this is not a long term solution
@layershifter Sorry I didn't have time last week to get this buttoned up. Thanks for getting this over the finish line and merged! |
@jluxenberg no worries, thanks for contributing 👍 |
In #3774 we started to use third party package for
Ref
component however docs for it also gone. And it was unclear... (#3915).This PR restores docs for
Ref
component and adds a clear statement when it should be used.