fix(Modal|Portal|Popup): use proposed value for open in onOpen & onClose callbacks

[layershifter]

Fixes #1280.

---

⚠️ BREAKING CHANGES

This PR contains breaking changes in API.

It updates the behavior of onOpen & onClose callbacks in Modal, Popup & Portal components.

The open prop in the data param to callbacks will be the proposed open value, not the current value as was before. This way, it can be used in an onOpen => open loop for a controlled component. Identical to the onChange => value loop for an input, checkbox, etc. The value is the would-be-value should the update take effect, not the current controlled value.

Before

<>
  <Portal
    onOpen={(e, data) => console.log(data.open /* open = false */)}
    onClose={(e, data) => console.log(data.open /* open = true */)}
  />
  <Modal
    onOpen={(e, data) => console.log(data.open /* open = false */)}
    onClose={(e, data) => console.log(data.open /* open = true */)}
  />
</>

<Portal
  onOpen={(e, data) => setOpen(true)}
  onClose={(e, data) => setOpen(false)}
/>

After

<>
  <Portal
    onOpen={(e, data) => console.log(data.open /* open = true */)}
    onClose={(e, data) => console.log(data.open /* open = false */)}
  />
  <Modal
    onOpen={(e, data) => console.log(data.open /* open = true */)}
    onClose={(e, data) => console.log(data.open /* open = false */)}
  />
</>

{/* This usage is unblocked now */}
<Portal
  onOpen={(e, data) => setOpen(data.open)}
  onClose={(e, data) => setOpen(data.open)}
/>

[github-actions]

size-limit report

Path	Size
bundle-size/dist/Button.size.js	66.48 KB (+0.04% 🔺)
bundle-size/dist/Icon.size.js	30.65 KB (0%)
bundle-size/dist/Image.size.js	61.72 KB (+0.04% 🔺)
bundle-size/dist/Modal.size.js	76.79 KB (+0.09% 🔺)
bundle-size/dist/Portal.size.js	47.8 KB (+0.05% 🔺)

[codecov-commenter]

Codecov Report

Merging #4030 into next-v2 will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           next-v2    #4030      +/-   ##
===========================================
- Coverage    99.84%   99.84%   -0.01%     
===========================================
  Files          183      183              
  Lines         3280     3278       -2     
===========================================
- Hits          3275     3273       -2     
  Misses           5        5              

Impacted Files	Coverage Δ
src/addons/Portal/Portal.js	100.00% <100.00%> (ø)
src/modules/Modal/Modal.js	100.00% <100.00%> (ø)
src/modules/Popup/Popup.js	98.75% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40903c2...a651bea. Read the comment docs.

[layershifter]

Released in semantic-ui-react@2.0.0 🚢