docs(mixed): add gender other to gender selectors #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3524 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 172 172
Lines 2795 2795
=======================================
Hits 2790 2790
Misses 5 5Continue to review full report at Codecov.
|
src/lib/SUI.js
Outdated
| @@ -609,6 +609,7 @@ export const GENDERS = [ | |||
| 'mars stroke vertical', | |||
| 'mercury', | |||
| 'neuter', | |||
| 'other', | |||
There was a problem hiding this comment.
This array contains definitions for existing icons, please revert this change.
There was a problem hiding this comment.
ff96fdc should fix it
layershifter
changed the title
|
Congrats on merging your first pull request! 🎉🎉🎉 |
mbakiev
pushed a commit
to mbakiev/Semantic-UI-React
that referenced
this pull request
Jun 17, 2019
docs(mixed): add gender other to gender selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a gender neutral option in the selectors in examples as I felt some communities might be impacted by the binary choice here.