Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Dropdown|Select|Visibility): remove imports, use faker and components #3486

Merged
merged 4 commits into from
Mar 10, 2019

Conversation

layershifter
Copy link
Member

This PR partially fixes the old issue: all examples should be copy-pastable, so they should not contain internal imports.

Refs #3479.

@codecov-io
Copy link

Codecov Report

Merging #3486 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3486   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         172      172           
  Lines        2802     2802           
=======================================
  Hits         2797     2797           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5086470...d28d5b5. Read the comment docs.

@layershifter layershifter merged commit 8947b0b into master Mar 10, 2019
@layershifter layershifter deleted the docs/remove-imports branch March 10, 2019 10:49
@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants