Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Layouts): fix examples with incorrect props #3227

Merged

Conversation

AlanFoster
Copy link
Contributor

Hey, I noticed that some of the docs were using invalid React props. I've got ahead and fixed the issues I could spot within docs/layouts, and if I notice any other examples being wrong in the future I'll update them too 👍

@welcome
Copy link

welcome bot commented Oct 18, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3227 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3227   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2790     2790           
=======================================
  Hits         2788     2788           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845c347...0f53a22. Read the comment docs.

@AlanFoster AlanFoster force-pushed the fix-docs-using-incorrect-props branch from 0f53a22 to 92f04d8 Compare October 18, 2018 20:45
@AlanFoster AlanFoster force-pushed the fix-docs-using-incorrect-props branch from 92f04d8 to 3f95602 Compare October 18, 2018 20:46
@layershifter layershifter changed the title Fix docs using incorrect props docs(Layouts): fix examples with incorrect props Oct 20, 2018
@layershifter layershifter merged commit 199eef6 into Semantic-Org:master Oct 20, 2018
@welcome
Copy link

welcome bot commented Oct 20, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@layershifter
Copy link
Member

@AlanFoster thank you, great job 👍

@AlanFoster AlanFoster deleted the fix-docs-using-incorrect-props branch October 20, 2018 09:11
@levithomason
Copy link
Member

Released in semantic-ui-react@0.83.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants