Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Sticky): add styleElement prop #3202

Merged

Conversation

Wattenberger
Copy link
Contributor

A small change to preserve any styles passed to Sticky to fix #2908

@welcome
Copy link

welcome bot commented Oct 9, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #3202 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3202      +/-   ##
==========================================
+ Coverage   99.92%   99.92%   +<.01%     
==========================================
  Files         169      169              
  Lines        2801     2802       +1     
==========================================
+ Hits         2799     2800       +1     
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Sticky/Sticky.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d5da8...78a95af. Read the comment docs.

@layershifter
Copy link
Member

@Wattenberger thank you, I made some changes 👍

@layershifter layershifter changed the title fix(Sticky): retain passed style (#2908) fix(Sticky): retain passed style Oct 10, 2018
@layershifter layershifter changed the title fix(Sticky): retain passed style feat(Sticky): add styleElement element prop Oct 23, 2018
@layershifter layershifter changed the title feat(Sticky): add styleElement element prop feat(Sticky): add styleElement prop Oct 23, 2018
@layershifter layershifter merged commit 73f7d05 into Semantic-Org:master Oct 23, 2018
@welcome
Copy link

welcome bot commented Oct 23, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticky: div does not inherit z-index
3 participants