Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Sticky): add warning about erratic behavior inside Sidebar.Pushable #2936

Merged
merged 4 commits into from
Mar 6, 2019

Conversation

brambow
Copy link
Contributor

@brambow brambow commented Jun 22, 2018

Sticky elements have erratic behavior inside Sidebar.Pushable.

See: #2897 and #2462
Also see: Semantic-Org/Semantic-UI#1745

This PR adds a warning message in the Sticky docs about this erratic behavior and suggests placing Sticky elements outside any Sidebar.Pushable elements.

@welcome
Copy link

welcome bot commented Jun 22, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@brambow brambow changed the title Sticky docs warning Sticky docs warning: erratic behavior in Sidebar.Pushable Jun 22, 2018
@stale
Copy link

stale bot commented Dec 19, 2018

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Dec 19, 2018
@stale stale bot removed the stale label Mar 6, 2019
@layershifter layershifter changed the title Sticky docs warning: erratic behavior in Sidebar.Pushable docs(Sticky): add warning about erratic behavior inside Sidebar.Pushable Mar 6, 2019
@layershifter layershifter merged commit ce521fc into Semantic-Org:master Mar 6, 2019
@welcome
Copy link

welcome bot commented Mar 6, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants