Skip to content

Conversation

@layershifter
Copy link
Member

Fixes #1875.

@codecov-io
Copy link

Codecov Report

Merging #2119 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2119   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         150      150           
  Lines        2596     2596           
=======================================
  Hits         2590     2590           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c003fe9...8978737. Read the comment docs.

@levithomason
Copy link
Member

Since this is already submitted, I'll merge. However, I want to avoid any fixes for using children with the Dropdown and instead direct users to use the options prop.

I'm afraid we'll end up on a slippery slope of fixing small issues with children constantly, thereby supporting it.

@levithomason levithomason merged commit 1ae4931 into master Sep 25, 2017
@levithomason levithomason deleted the fix/dropdown-undefined branch September 25, 2017 14:55
@levithomason
Copy link
Member

Released in semantic-ui-react@0.74.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants