Popup: invalid typings for `on` property

[daigof]

Bug Report

Steps

Use Popup component and try to use the on property as array
<Popup on={['hover', 'click']}

It throws TS error: Type '"hover"' is not assignable to type '"focus"'

Issue may be with prop declaration:

/** Events triggering the popup. */
on?: 'hover' | 'click' | 'focus' | 'hover' | 'click' | 'focus'[]

Expected Result

Expect to use array form of prop with all permitted values

Actual Result

Only can use an array of ['focus'] and not any other

Version

1.1.1

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

[layershifter]

Thanks for reporting 👍 It's the same as #4013 i.e. typings issue 😿

---

src/modules/Popup/Popup.d.ts

  /** Events triggering the popup. */
-  on?: 'hover' | 'click' | 'focus' | 'hover' | 'click' | 'focus'[]
+  on?: 'hover' | 'click' | 'focus' | ('hover' | 'click' | 'focus')[]

And the same for Visibility:

src/behaviors/Visibility/Visibility.d.ts

  /**
   * Value that context should be adjusted in pixels. Useful for making content appear below content fixed to the
   * page.
   */
-  offset?: number | string | number | string[]
+  offset?: number | string | (number | string)[]

Would you like to a submit a PR to fix the issue? 😺

[daigof]

sure will do...

PR opened: #4019