Add better linting when an action is modified inside an agent #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioz
reviewed
May 6, 2025
sema4ai/src/sema4ai_code/vendored_deps/package_deps/analyzer.py
Outdated
Show resolved
Hide resolved
fabioz
reviewed
May 8, 2025
| fs_path = uris.to_fs_path(doc_uri) | ||
|
|
||
| # Handle Sema4.ai folder files changes with warning message | ||
| if "Sema4.ai" in fs_path: |
There was a problem hiding this comment.
The one detail is that this should also only be done if it's an action package inside an agent package with the Sema4.ai being found between those (i.e.: if the user puts everything they do related to Sema4.ai in a root folder, we shouldn't trigger this condition due to that).
fabioz
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable release checklist:
python -m dev set-version {version}/docs/changelog.mdwith the changes for the releasePre-release checklist:
/docs/changelog.mdwith the new changes.