Fix the problem that it closes all tabs when using webdriver.close() to close the current tab in Edge IE Mode.

[yk9772]

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Let it go the same way in Edge IE Mode as in IE when closing the current tab(window).

Motivation and Context

To solve the problem that it closes all active tabs(windows) when using webdriver.close() to close the current tab(window) in Edge IE Mode.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[CLAassistant]

All committers have signed the CLA.

[jimevans]

@guangyuexu What would be the implications of this change after merging your pending PR?

[bwalderman]

I see the CloseWindowCommandHandler and the QuitCommandHandler both use Browser::Close, and the key difference is that QuitCommandHandler iterates through all managed Browsers instead of just one.

In IE Mode, this will correctly terminate all of the underlying IE processes, but for the Quit command we should still make sure the parent Edge process is cleaned up to. I'd recommend keeping the PostMessage(GetTopLevelWindowHandle(), WM_CLOSE, 0, 0); call. This should be the last step after all of the managed Browser objects have been closed.

[jimevans]

@bwalderman Noted. I'll merge this one, and move the PostMessage call to a more appropriate place.

[jimevans]

@yk9772 Thank you for your contribution!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information