Fixing issue #5079 (FluentWait.until(Predicate) method does not propagate predicate message)#7
Closed
usultis wants to merge 1 commit intoSeleniumHQ:masterfrom
Closed
Fixing issue #5079 (FluentWait.until(Predicate) method does not propagate predicate message)#7usultis wants to merge 1 commit intoSeleniumHQ:masterfrom
usultis wants to merge 1 commit intoSeleniumHQ:masterfrom
Conversation
… not propagate predicate message). adding toString method to the constructed Function when doing FluentWait.until(Predicate) so that it can be picked up in the exception message
Member
|
Have you signed the CLA at http://goo.gl/qC50R? |
Contributor
Author
|
yes (yesterday) |
Member
|
Merged into trunk of canonical tree: https://code.google.com/p/selenium/source/detail?r=1977be9bcd9d8f52c4e21055fa2a28071464a0e8 Thank you for the patch! |
IlyaNaumovich
added a commit
to IlyaNaumovich/selenium
that referenced
this pull request
Feb 11, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #5079
adding toString method to the constructed Function when doing FluentWait.until(Predicate) so that it can be picked up in the exception message