-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Remove obsoleted FtpProxy #16411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nvborisenko
merged 1 commit into
SeleniumHQ:trunk
from
nvborisenko:dotnet-obsolete-ftp-proxy
Oct 11, 2025
Merged
[dotnet] Remove obsoleted FtpProxy #16411
nvborisenko
merged 1 commit into
SeleniumHQ:trunk
from
nvborisenko:dotnet-obsolete-ftp-proxy
Oct 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
RenderMichael
approved these changes
Oct 11, 2025
This was referenced Oct 19, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This pull request removes support for FTP proxies from the
Proxyclass and its related tests. The changes simplify the codebase by eliminating theFtpProxyproperty, its serialization, and all associated logic and tests. This aligns with the previous deprecation notice and helps maintain a cleaner, more focused proxy implementation.💥 What does this PR do?
FtpProxyproperty, its backing field, and related logic from theProxyclass, including JSON serialization and dictionary conversion.ftpProxykey in theProxy(Dictionary<string, object> settings)constructor.🔄 Types of changes
PR Type
Other
Description
Remove deprecated
FtpProxyproperty from Proxy classClean up related serialization and constructor logic
Update all associated unit tests
Diagram Walkthrough
File Walkthrough
Proxy.cs
Remove FtpProxy property and related logicdotnet/src/webdriver/Proxy.cs
ftpProxyLocationfield andFtpProxypropertyProxyTest.cs
Remove FtpProxy test assertionsdotnet/test/common/ProxyTest.cs
FtpProxyassertions from test methods