-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Added Selenium WebDriver Test Template using Bazel #16142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
I am not sure what the PR is actually trying to do. Seems that AI generated it. |
User description
🔗 Related Issues
Fixes #1234
💥 What does this PR do?
This PR adds a new feature that allows users to configure timeouts globally for all WebDriver instances, improving test stability and reducing flaky test failures. It introduces a new
TimeoutConfig
class and updates the driver initialization process.🔧 Implementation Notes
The timeout configuration is injected into the WebDriver builder to maintain backward compatibility. Alternative approaches such as modifying each WebDriver method individually were considered but deemed too invasive.
💡 Additional Considerations
Documentation will need to be updated to reflect the new global timeout configuration option. Additionally, we plan to add similar support for remote WebDriver instances in a follow-up PR.
🔄 Types of changes
Cleanup (formatting, renaming)
Refactored the WebDriver initialization code to improve readability and remove deprecated API usage.
Bug fix (backwards compatible)
Fixed an issue where FirefoxDriver would hang indefinitely when a proxy was misconfigured.
New feature (non-breaking change which adds functionality and tests!)
Added support for global timeout configuration for all WebDriver instances, including unit tests.
Breaking change (fix or feature that would cause existing functionality to change)
Changed the WebDriver API method
start()
toinitialize()
for clarity, requiring updates to user code.PR Type
Other
Description
Added Java WebDriver test template with Bazel integration
Includes basic browser setup and test structure
Provides example for Chrome WebDriver configuration
Contains template for common WebDriver operations
Diagram Walkthrough
File Walkthrough
empty_test_template.txt
New Java WebDriver test template
java/empty_test_template.txt