[dotnet] [bidi] Support WebExtension module

[nvborisenko]

User description

https://w3c.github.io/webdriver-bidi/#module-webExtension

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

• Cleanup (formatting, renaming)
• Bug fix (backwards compatible)
• New feature (non-breaking change which adds functionality and tests!)
• Breaking change (fix or feature that would cause existing functionality to change)

---

PR Type

Enhancement, Tests

---

Description

• Add BiDi WebExtension module for installing/uninstalling extensions

• Implement WebExtension install/uninstall commands and types

• Integrate WebExtension support into BiDi broker and serializer

• Add comprehensive tests for WebExtension install/uninstall

• Update test project to include extension test data

---

Changes walkthrough 📝

	Relevant files
Enhancement	8 files BiDi.cs Integrate WebExtension module into BiDi client                      +3/-0      Broker.cs Register WebExtensionConverter in BiDi broker                        +1/-0      BiDiJsonSerializerContext.cs Add WebExtension commands/results to serializer context    +4/-0      WebExtensionConverter.cs Add JSON converter for WebExtension type                                  +47/-0    Extension.cs Implement WebExtension Extension class with uninstall        +40/-0    InstallCommand.cs Define install command and types for WebExtension                +44/-0    UninstallCommand.cs Define uninstall command and options for WebExtension        +29/-0    WebExtensionModule.cs Implement WebExtensionModule with install/uninstall methods +40/-0
Tests	1 files WebExtensionTest.cs Add tests for WebExtension install/uninstall scenarios      +76/-0
Configuration changes	1 files WebDriver.Common.Tests.csproj Include extension test data in test project                            +4/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌ 1234 - Not compliant Non-compliant requirements: • Fix issue where Selenium 2.48 doesn't trigger JavaScript in link's href on click() in Firefox 42.0 • Ensure JavaScript alerts are triggered properly when clicking links with JavaScript in href attribute 5678 - Not compliant Non-compliant requirements: • Fix "ConnectFailure (Connection refused)" error when instantiating ChromeDriver multiple times • Ensure subsequent ChromeDriver instances can be created without connection errors

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Method Visibility The UninstallAsync method is marked as internal while it's being called from the public Extension class. Consider making this method public for consistency and to allow direct uninstallation without going through the Extension object. internal async Task UninstallAsync(Extension extension, UninstallOptions? options = null) { var @params = new UninstallCommandParameters(extension); await Broker.ExecuteCommandAsync(new UninstallCommand(@params), options).ConfigureAwait(false); }

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Fix inheritance contradiction The InstallResult class inherits from EmptyResult but also contains an Extension property, which is contradictory. Either make it a standalone result class or ensure it properly extends the base class without conflicting behavior. dotnet/src/webdriver/BiDi/WebExtension/InstallCommand.cs [44] -public record InstallResult(Extension Extension) : EmptyResult; +public record InstallResult(Extension Extension); Apply / Chat Suggestion importance[1-10]: 2 __ Why: The suggestion assumes EmptyResult means no properties are allowed, but this may not be accurate. Removing the inheritance could break expected functionality without understanding the base class purpose.	Low
More

[nvborisenko]

Test fails on CI, because I don't know how to prepare test data in bazel test environment. It passes locally in IDE and dotnet test.